Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test for #587 #589

Merged
merged 2 commits into from
Jan 10, 2020
Merged

test for #587 #589

merged 2 commits into from
Jan 10, 2020

Conversation

vy
Copy link
Contributor

@vy vy commented Jan 2, 2020

No description provided.

@cowtowncoder cowtowncoder changed the title test for #588 test for #587 Jan 7, 2020
@cowtowncoder
Copy link
Member

cowtowncoder commented Jan 8, 2020

PR looks good; just one practical thing: unless I have asked for and gotten (apologies if I missed it, tried to check) for CLA, would need one now before merge. CLA doc is here:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

and usually the simplest way is to print, fill in, sign, scan/snapshot, and email.
Email should usually go to fasterxml.com address but right now there seem to be issues so please send to tsaloranta at gmail dot com.

Thank you once again for this contribution!

@vy
Copy link
Contributor Author

vy commented Jan 9, 2020

Have just filled in, signed, and e-mailed the CLA.

@cowtowncoder
Copy link
Member

@vy Ok good. Just one quick note: I realized that somehow all fasterxml addressed are failing for now (trying to resolve), so make sure to send to gmail address I mention above. Mentioning this since I do not yet see the CLA. Could be just delayed of course.

@vy
Copy link
Contributor Author

vy commented Jan 10, 2020

Sorry, totally forgot about that e-mail detail. Forwarded the e-mail to your gmail address.

@cowtowncoder cowtowncoder merged commit 662bddc into FasterXML:master Jan 10, 2020
@cowtowncoder cowtowncoder added this to the 2.11.0 milestone Jan 10, 2020
cowtowncoder pushed a commit that referenced this pull request Jan 10, 2020
Fix #587 Add JsonGenerator#writeNumber(char[],int,int) methods, tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants